-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change license to MIT #494
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 82.64% 82.71% +0.07%
==========================================
Files 51 51
Lines 2823 2823
Branches 312 312
==========================================
+ Hits 2333 2335 +2
+ Misses 366 365 -1
+ Partials 124 123 -1 ☔ View full report in Codecov by Sentry. |
@chmorgan could you review this? the coverage change seems to be sporadic due to https://github.com/dotpcap/sharppcap/blob/master/SharpPcap/WinDivert/WinDivertDevice.cs#L140-L154 block having the lines covered change depending on packet count/buffer size. |
# Conflicts: # .appveyor.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview of this looks good to me. Did you generate this by hand or some application that went through git history to update it?
@kayoub5 oh and no idea on the coverage issue. Surprised we'd get different results on different runs but maybe we have some tests that use random data without using a fixed random number seed. |
For license I used a reuse-tool to inject the MIT header. |
No description provided.